-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for top toolbar block selection with no block toolbar #57291
Conversation
There are some instances where a block can be selected but no block toolbar shows. This is a messy approach but duplicates the return null check from BlockToolbar into useCanBlockToolbarBeFocused. I think it would be better to combine the null check from BlockToolbar into its own hook so that hook can be used within useCanBlockToolbarBeFocused.
// The same check used in <BlockToolbar /> to see if it should return null. | ||
// Should we combine these into their own hook so they stay consistent? | ||
const noBlockToolbar = | ||
! isToolbarEnabled || | ||
( ! isDefaultEditingMode && ! hasAnyBlockControls ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having the "should we show the block toolbar" check within <BlockToolbar />
and this check should be combined into a new "showBlockToolbar" hook that can get used here.
Size Change: +123 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Flaky tests detected in dcf58ec. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7281517797
|
Fixes #57288.
What?
There are some instances where a block can be selected but no block toolbar shows in the header.
Why?
Bug fix to show the central document command center in the template editor.
How?
This is a messy approach but duplicates the return null check from BlockToolbar into useCanBlockToolbarBeFocused. I think it would be better to combine the null check from BlockToolbar into its own hook so that hook can be used within useCanBlockToolbarBeFocused.
TODO
null
check in<BlockToolbar />
to its own check and use it withinuseCanBlockToolbarBeFocused
?Testing Instructions