Performance: Avoid extra useMarkPersistent dispatch calls
#57435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
requested review from
ellatrix,
fluiddot and
dcalhoun
as code owners
|
Size Change: +2 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Dec 28, 2023
ellatrix
deleted the
performance/avoid-useMarkPersistent-dispatch-calls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR tries to improve the block selection performance by avoiding extra dispatching calls. We do that by always converting the
hasActiveFormatsto aboolean, because at cases(like the creation of a new record) theactiveFormatscan beundefinedand then anarray.