Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/tutorial: Fix opposite condition for content generation in render.php #57445

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

atachibana
Copy link
Contributor

What?

In the "Optimizing render.php" section,

Therefore, update the file to render the $block_content if currentYear and fallbackCurrentYear match.

But, the block content should be updated if currentYear and fallbackCurrentYear do not match.
Also, the previous sentence of it says:

It is already saved in the database and is available in the render.php file via the $block_content variable.

It must be $content, not $block_content.

And, some minor fixes were included.

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Copy link
Member

@ndiego ndiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these @atachibana 🙏

@ndiego ndiego merged commit 2888084 into WordPress:trunk Dec 29, 2023
55 of 60 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.5 milestone Dec 29, 2023
@atachibana
Copy link
Contributor Author

@ndiego Thanks.
By the way, this tutorial is incredible. Especially the way you introduced the editor side and the front end side neatly separated and brought save.js in the second half was a very good structure. I could easily follow the context. Thank you so much for the great work!

@ndiego
Copy link
Member

ndiego commented Dec 29, 2023

Thanks so much for the kind feedback @atachibana 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants