[RNMobile] Ensure Aztec input state function blurOnUnmount updates its state
#57486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
geriux
approved these changes
Jan 2, 2024
fluiddot
merged commit 63a0e09
into
feat/unselect-block-with-back-button
60 checks passed
geriux
pushed a commit
that referenced
this pull request
Jan 2, 2024
…7279) * Mobile - WPAndroidGlueCode - Implement BackHandler functionality * Mobile - Editor Provider - Add BackHandler listener to unselect blocks * Mobile - Jest setup - Adds BackHandler mocks * Mobile - Edit post tests - Adds test for unselecting blocks using the hardware back button * Track when it should handle the back press button for cases when there's another activity instanced and the editor is in the background * Mobile - Keyboard Handling on Android - Set currentFocusedElement to null when hiding the soft keyboard. It also adds a check to not attempt to show the soft keyboard if there's no element set in currentFocusedElement * Update Changelog * Use InputState isFocused method instead of manually checking if there's a focused element * [RNMobile] Ensure Aztec input state function `blurOnUnmount` updates its state (#57486) * Ensure `blurOnUnmount` updates internal input state * Add unit test to cover `blurOnUnmount` logic --------- Co-authored-by: Carlos Garcia <fluiddot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates
blurOnUnmountfunction to ensure the input state is updated due to the blur event.Why?
Currently, if an Aztec view is unmounted the Aztec input state still references the removed view as focused.
How?
The function
dismissKeyboardDebouncehas been replaced withblurOnUnmountDebounce, which implements the following logic:notifyInputChangeas we can't rely on the state of the internalTextInputStatedue to not actively triggering the blur event.Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A