Entities: Add config to read and write transient edits from edited post #57500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Technical Prototype
youknowriad
requested review from
nerrad,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Size Change: +106 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Jan 25, 2024
|
I think we really need something like this at some point but it would require commitment and time which I don't have for this particular PR at some point. Maybe folks like @jsnajdr or other that are familiar with the data package could resurface it at some point but for now, let's just close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In several places, we want to access the "blocks" properly of a post/page before making any edits. the problem is the "blocks" property is not a regular post/page property, it's just a temporary property that is set when editing the post/page in a block editor. We used to solve this by either:
Both are bad solutions:
How?
This PR is an attempt to a third alternative. Basically we add awareness of how to read and write these transient properties to the core-data framework and ensure the selectors returns the transient properties as prefilled from the start with or without edits.
Testing Instructions
Mostly relying on e2e tests here and previous experiences.