Migrate 'invalid blocks' e2e tests to Playwright #57508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
requested review from
WunderBart
and removed request for
ntwb,
ajitbohra and
nerrad
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
kevin940726
approved these changes
Jan 4, 2024
| await expect( | ||
| page | ||
| .getByRole( 'dialog', { name: 'Resolve Block' } ) | ||
| .locator( '.block-editor-block-compare__html' ) |
There was a problem hiding this comment.
I guess we can just omit this class name selector as this doesn't provide any helpful accessible query?
There was a problem hiding this comment.
This narrows down the text content we want to assert. The dialog contains other text.
Update: We should make really odd assertion otherwise 😅
Screenshots
There was a problem hiding this comment.
I see!
Would toContainText work?
There was a problem hiding this comment.
Same problem with toContainText. Considering that tests assert resolution diff, I think it's okay to use class name locator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
PR migrates
invalid-block.test.jse2e tests to Playwright.Why?
See #38851.
Testing Instructions