-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up code editor CSS. #57519
Merged
Merged
Clean up code editor CSS. #57519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Feature] Code Editor
Handling the code view of the editing experience
[Type] Code Quality
Issues or PRs that relate to code quality
labels
Jan 3, 2024
Size Change: -35 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Code Editor
Handling the code view of the editing experience
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #21643
Part of an effort to remove all the CSS
order
properties from the codebase.What?
Trivial PR to clean-up some leftovers. #21643 removed the icon shown in the 'Exit code editor' button but there's still a couple CSS rules to swap the position of the removed icon.
Why?
Beginning of the year cleaning.
How?
order
CSS property set to a no longer used SVG icon.padding
declaration.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast