Editor: Unify the top toolbar preference #57531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
24 tasks
|
Size Change: -25 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Jan 4, 2024
| @@ -34,14 +33,12 @@ function Editor( { | |||
| initialEdits, | |||
| ...props | |||
| } ) { | |||
| const isLargeViewport = useViewportMatch( 'medium' ); | |||
There was a problem hiding this comment.
We don't need this check any more? I think we do and now in smaller viewports display both toolbars.
There was a problem hiding this comment.
Good catch. The later ! isLargeViewport check does toggle the fixed toolbar setting on for mobile devices. So we should find a way to preserve it or architect it differently.
youknowriad
force-pushed
the
update/unify-top-toolbar-pref
branch
from
26ce3cd to
85631b5
Compare
|
What's remaining here? |
ntsekouras
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
Similar to #57468
What?
This PR continues the work on the great unification between post and site editors. In this PR we're unifying the "Top toolbar" preference. If the user enables it in the post editor, the setting should be used in the site editor as well.
Testing instructions