-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate 'scheduling' e2e tests to Playwright #57539
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
65 changes: 0 additions & 65 deletions
65
packages/e2e-tests/specs/editor/various/scheduling.test.js
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
const { test, expect } = require( '@wordpress/e2e-test-utils-playwright' ); | ||
|
||
// The `timezone` setting exposed via REST API only accepts `UTC` | ||
// and timezone strings by location. | ||
const TIMEZONES = [ 'Pacific/Honolulu', 'UTC', 'Australia/Sydney' ]; | ||
|
||
test.describe( 'Scheduling', () => { | ||
TIMEZONES.forEach( ( timezone ) => { | ||
test.describe( `Timezone ${ timezone }`, () => { | ||
let orignalTimezone; | ||
test.beforeAll( async ( { requestUtils } ) => { | ||
orignalTimezone = ( await requestUtils.getSiteSettings() ) | ||
.timezone; | ||
|
||
await requestUtils.updateSiteSettings( { timezone } ); | ||
} ); | ||
|
||
test.afterAll( async ( { requestUtils } ) => { | ||
await requestUtils.updateSiteSettings( { | ||
timezone: orignalTimezone, | ||
} ); | ||
} ); | ||
|
||
test( 'Should change publishing button text from "Publish" to "Schedule"', async ( { | ||
admin, | ||
editor, | ||
page, | ||
} ) => { | ||
await admin.createNewPost(); | ||
await editor.openDocumentSettingsSidebar(); | ||
|
||
const topBar = page.getByRole( 'region', { | ||
name: 'Editor top bar', | ||
} ); | ||
|
||
await expect( | ||
topBar.getByRole( 'button', { name: 'Publish' } ) | ||
).toBeVisible(); | ||
|
||
// Open the datepicker. | ||
await page | ||
.getByRole( 'button', { name: 'Change date' } ) | ||
.click(); | ||
|
||
// Change the publishing date to a year in the future. | ||
await page | ||
.getByRole( 'group', { name: 'Date' } ) | ||
.getByRole( 'spinbutton', { name: 'Year' } ) | ||
.click(); | ||
await page.keyboard.press( 'ArrowUp' ); | ||
|
||
// Close the datepicker. | ||
await page.keyboard.press( 'Escape' ); | ||
|
||
await expect( | ||
topBar.getByRole( 'button', { name: 'Schedule…' } ) | ||
).toBeVisible(); | ||
} ); | ||
} ); | ||
} ); | ||
|
||
test( 'should keep date time UI focused when the previous and next month buttons are clicked', async ( { | ||
admin, | ||
editor, | ||
page, | ||
} ) => { | ||
await admin.createNewPost(); | ||
await editor.openDocumentSettingsSidebar(); | ||
await page.getByRole( 'button', { name: 'Change date' } ).click(); | ||
|
||
const calendar = page.getByRole( 'application', { name: 'Calendar' } ); | ||
const prevMonth = calendar.getByRole( 'button', { | ||
name: 'View previous month', | ||
} ); | ||
const nextMonth = calendar.getByRole( 'button', { | ||
name: 'View next month', | ||
} ); | ||
|
||
await prevMonth.click(); | ||
await expect( prevMonth ).toBeFocused(); | ||
await expect( calendar ).toBeVisible(); | ||
|
||
await nextMonth.click(); | ||
await expect( nextMonth ).toBeFocused(); | ||
await expect( calendar ).toBeVisible(); | ||
} ); | ||
} ); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Could we move the loop to close to the
test
function so that we only have to get the original timezone once? We can then callupdateSiteSettings
inbeforeEach
or inside the test too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try it, though I don't think it should affect test speed in this case.
Update: I tried rearranging things, but I don't think it's worth it for a single test in a loop. Rearrangement introduces more setup and cleanup steps.