Iframe: calc compat styles once per page load #57798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +7 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 71f1811. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7514492174
|
ellatrix
force-pushed
the
fix/calc-compat-styles-once
branch
from
b4c60a4 to
71f1811
Compare
jsnajdr
reviewed
Jan 22, 2024
| function matchFromRules( _cssRules ) { | ||
| return Array.from( _cssRules ).find( | ||
| ( { | ||
| selectorText, |
There was a problem hiding this comment.
@ellatrix On WP.com, I'm seeing an error being thrown on this line:
Error: Permission denied to access property "selectorText"
Any idea what could it be? It happens in Firefox, Chrome seems to be fine.
There was a problem hiding this comment.
This didn't happen previously? I didn't really change anything here, I just moved the code to a new file.
There was a problem hiding this comment.
I don't know, it just started happening randomly on a draft post. And after closing and opening the same post in a new tab the error disappeared again, so I don't really have any steps to reproduce.
But I'm wondering what "Permission denied to access property" even means. It's like the stylesheet object was from a cross-origin iframe, and therefore behind some security boundary.
There was a problem hiding this comment.
That's why there's a try/catch for accessing styleSheet.cssRules, normally it fails there for cross origin stylesheets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently we calculate the compatibility styles for every iframe separately. These styles don't change after load, so they can be reused.
Why?
First run: -10% (load patterns)
Second run also -10%
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast