Update Templates table layout #57930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Experimental
|
Size Change: +111 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
All of the following are almost certainly separate, but mentioning it just as I observe it: we need to be smarter about the column widths, and probably employ percentages (ideally percentages combined with min-widths if possible), so that you can scale the viewport down further before it starts requiring horizontal scroll. Specifically here fore Templates, it seems the title column is very wide, and I wonder if the description should not be a separate column, but rather helper text below the title, making for taller rows but fewer columns. Finally, this may be related to the separate preview thumbnail work that's going on, but the table looks indented from the left. |
Yup I think this could be the way to go, it would improve the mobile experience too. It's not currently possible to combine fields into cells this way, but we also need it for #56976 cc @oandregal since we were chatting about this yesterday. |
The concern with "merging fields" into a single cell is what to do with operations such as editing, for example. Right now, cell-field is 1:1 relationship.
It should be doable to do this, though still a bit more complex than a 1:1 case. Because the fields are declared as "special" (they are the "media field" and the "primary field"), dataviews would know how to tell them apart and provide the adequate editing affordances for both. In any case, I think we should have a basic editing experience in place before exploring "merging fields". |
|
If a field is editable then the value would need to be wrapped in an interactive element like a Alternatively we might say that merged fields cannot be edited inline. Users can always edit via secondary actions (#55101). |
We'd have to have a "merge fields API" for this. If we simply use the
For this, we could just say a field is not editable ( |
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improve the overall layout of the Manage templates table.
Why?
This is best described in video, here's the current templates table:
before.mp4
And here's this PR:
after.mp4
Changes / fixes include:
How?
The
white-space: nowrap+width: 1%trick is applied to table cells so that they 'hug' their contents. On larger screens amin-widthis applied to stop columns appearing too dense on right-hand side of the table.A wrapper was added to the table markup (making use of an existing div) which is then used to facilitate horizontal scrolling.
Testing Instructions
Follow-ups