Update SearchControl consumers #58014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Package] Components
|
Size Change: -215 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9fea446. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7836690152
|
mirka
force-pushed
the
refactor/search-control-consumers
branch
from
c941a6d to
0360682
Compare
This was referenced Jan 19, 2024
mirka
force-pushed
the
refactor/search-control-consumers
branch
from
0360682 to
41abdb2
Compare
mirka
force-pushed
the
refactor/search-control-consumers
branch
from
41abdb2 to
4d4099b
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
approved these changes
Feb 6, 2024
| @@ -108,10 +108,6 @@ $block-inserter-tabs-height: 44px; | |||
|
|
|||
| .block-editor-inserter__search { | |||
| padding: $grid-unit-20 $grid-unit-20 0 $grid-unit-20; | |||
There was a problem hiding this comment.
Not related to this PR necessarily, but I think technically it would be better to add margin, instead of padding — at least more future-proof!
|
Working well for me. Feels good to remove those overrides 💪 |
mirka
force-pushed
the
refactor/search-control-consumers
branch
from
4d4099b to
9330675
Compare
|
This branch is also up to date with the latest changes. Screenshots are all updated, and I checked for any new style override issues in existing component usages. For the scope of this PR, I maintained the current overrides so they look the same as before. In future efforts, we may want to consider more systematic theming or official variants. Of note was the New Template Modal, where I understand how you'd prefer not to have a borderless gray search box right above some other gray boxes: CleanShot.2024-02-08.at.01.37.12.mp4The ad hoc border color here is notably lighter (gray-300) than a standard InputControl border (gray-600), so that might be something to standardize in some way. |
|
@mirka since there's a desire to persist with the gray-background variant I'd be tempted to remove the overrides in the add template modal. The lighter border looks like an oversight and doesn't meet contrast requirements. What do you think? |
Sure, no problem. Done in a16b7b0 👍 |
mirka
force-pushed
the
refactor/search-control-consumers
branch
from
a16b7b0 to
9fea446
Compare
mirka
merged commit adb0b1f
into
refactor/search-control-input-control
27 of 53 checks passed
mirka
added a commit
that referenced
this pull request
Feb 8, 2024
* WIP * Confirm label working as expected * Simplify id * Simplify props * Fix types * Add `__nextHasNoMarginBottom` back compat * Add RTL todo * Add CSS classes * Adjust prefix/suffix * Add empty string fallback to `value` * Add placeholder * Reset webkit styles * Restore original onChange type signature * Make 40px by default This should be acceptable because the original default was even larger. * Support compact size * Adjust inner padding * Adjust close button size * Remove stylesheet * Tweak JSDocs * Add default label * Tweak story * Clean up * Update docs * Purify SuffixItem * Tighten icon margins * Support borderless gray * Restore original icon layout * Programatically remove any potential `disabled` prop * Align `value` fallback to null coalesce * Add GH handle for design team * Add changelog * Update SearchControl consumers (#58014) * Update SearchControl consumers * Revert overrides to New Template Modal --------- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #56524
What?
Adjusts the styling of consumers who had style overrides on SearchControl.
Why?
The SearchControl refresh in #56524 changes some styling.
How?
Remove outdated style overrides, and adds style adjustments where necessary.
Testing Instructions / Screenshots
NavigationcomponentSee the Navigation ▸ Search story in Storybook (
?path=/story/components-experimental-navigation--search). (This component is not used in the Gutenberg app and will likely be deprecated soon.)Block inserter / Media inserter
Patterns (Data views disabled)/wp-admin/site-editor.php?path=%2FpatternsThis view seems to have been retired already, since it isn't accessible anymore even when the "New admin views" experimental flag is disabled.
New Template Modal
Apply this patch to always show search control
/wp-admin/site-editor.php?path=%2Fwp_template%2Fall▸ "Add New Template" button ▸ Pages