-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate remaining 'inserting blocks' e2e tests to Playwright #58108
Conversation
Size Change: -526 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
Flaky tests detected in 5ba5380. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7636878508
|
b950331
to
a3f98f0
Compare
await admin.createNewPost(); | ||
await editor.openDocumentSettingsSidebar(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test expects the document settings sidebar to be open, otherwise keyboard navigation fails.
} ); | ||
|
||
// Check for regression of https://github.com/WordPress/gutenberg/issues/27586. | ||
test( 'can close the main inserter after inserting a single-use block, like the More block', async ( { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the test name here to reflect the intention better. Clicking on any black option in the inserter doesn't close it. The insertBlock
help utility provided the original test behavior.
5ba5380
to
6c78528
Compare
I have removed the skipped test. I think we are already covering those scenarios. |
1eb1151
to
42bf6e6
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN:
GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. This looks good to me! 💯
What?
Part of #38851.
PR migrates remaining active 'inserting blocks' e2e tests to Playwright.
Why?
See #38851
Note
One skipped test remains, but I wonder if it's worth migrating.
Besides the different types of inserter tests (already extensively covered), it also contains tests that should be part of the writing flow or shortcode block.
Testing Instructions