Tooltip: accept specific tooltip props #58125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Bug
|
Flaky tests detected in 7037929. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7626771912
|
ciampo
force-pushed
the
fix/tooltip-rest-props
branch
from
fbe6dcd
to
7037929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Narrow the type associated to the
Tooltipcomponent's prop to only the explicit component's propsWhy?
The type was widened in #57202, but the change is not necessary anymore after #57878 (and it can cause the component to behave unexpectedly in some cases).
How?
By not using
WordPressComponentPropswhen defining the type of the props object.Testing Instructions
This PR doesn't include any runtime changes.
Make sure that tests pass and that the project builds correctly.