Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #58193

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix typo #58193

merged 1 commit into from
Jan 24, 2024

Conversation

matiasbenedetto
Copy link
Contributor

What?

fix a typo

@github-actions GitHub Actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/experimental/fonts/font-library/class-wp-font-family-utils.php

@matiasbenedetto matiasbenedetto added the [Type] Bug An existing feature does not function as intended label Jan 24, 2024
pbking
pbking approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@pbking pbking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@github-actions GitHub Actions
Copy link

Flaky tests detected in d8db51d.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7641407586
📝 Reported issues:

@matiasbenedetto matiasbenedetto enabled auto-merge (squash) January 24, 2024 14:33
@matiasbenedetto matiasbenedetto merged commit f0bf6ab into trunk Jan 24, 2024
58 of 59 checks passed
@matiasbenedetto matiasbenedetto deleted the fix/typo-in-font-family-utils branch January 24, 2024 14:41
@github-actions github-actions bot added this to the Gutenberg 17.6 milestone Jan 24, 2024
@getdave getdave mentioned this pull request Jan 26, 2024
Closed
@getdave
Copy link
Contributor

getdave commented Jan 26, 2024

I noticed this PR was merged after I raised the PHP Sync Tracking Issue for WP 6.5 and has changed PHP files that may need backporting to WP Core.

I believe this will be backported as part of a single backport for the Fonts API. It's been added to the Tracking Issue.

@getdave getdave added the Needs PHP backport Needs PHP backport to Core label Jan 26, 2024
@youknowriad youknowriad added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Needs PHP backport Needs PHP backport to Core labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbking pbking pbking approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees
No one assigned
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Feature] Font Library [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 17.6
Development

Successfully merging this pull request may close these issues.
5 participants
@matiasbenedetto @getdave @pbking @youknowriad @cbravobernal