Fix Link UI popover anchor in rich text #58282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
|
Size Change: +2 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
getdave
commented
Jan 26, 2024
Comment on lines
+223
to
+225
| if ( ! isActive ) { | ||
| popoverAnchor.getBoundingClientRect = () => cachedRect; | ||
| } |
There was a problem hiding this comment.
If isActive is true then there is an existing link and thus we should allow popoverAnchor (derived from useAnchor) to use the default implementation which will seek the <a> in the DOM and anchor to that.
Otherwise if we're creating a link then there is no <a> until the link is submitted. Therefore we need to cache the anchor value of the original text selection that the user selected to be linked.
Previously we just cached the selection value always, which wasn't correct.
There was a problem hiding this comment.
This fixes it for existing links, but for new links, the popover will have the same scroll issue since its position is cached.
scruffian
approved these changes
Jan 26, 2024
westonruter
added a commit
that referenced
this pull request
Jan 26, 2024
…zy-hydration * origin/trunk: (47 commits) Interactivity API: Break up long hydration task in interactivity init (#58227) Add supports.interactivity to Query block (#58316) Font Library: Make notices more consistent (#58180) Fix Global styles text settings bleeding into placeholder component (#58303) Fix the position and size of the Options menu, (#57515) DataViews: Fix safari grid row height issue (#58302) Try a fix (#58282) Navigation Submenu Block: Make block name affect list view (#58296) Apply custom scroll style to fixed header block toolbar (#57444) Add support for transform and letter spacing controls in Global Styles > Typography > Elements (#58142) DataViews: Fix table view cell wrapper and BlockPreviews (#58062) Workflows: Add 'Technical Prototype' to the type-related labels list (#58163) Block Editor: Optimize the 'useBlockDisplayTitle' hook (#58250) Remove noahtallen from .wp-env codeowners (#58283) Global styles revisions: fix is-selected rules from affecting other areas of the editor (#58228) Try: Disable text selection for post content placeholder block. (#58169) Remove `template-only` mode from editor and edit-post packages (#57700) Refactored download/upload logic to support font faces with multiple src assets (#58216) Components: Expand theming support in COLORS (#58097) Implementing new UX for invoking rich text Link UI (#57986) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes bug where Link UI Popover anchor becomes divorced from the link that "owns" it (see Issue).
Closes #58280
Why?
The Link UI should always be anchored to the link that was clicked/activated.
How?
Ensures that the anchor position is allowed to be dynamically calculated for existing links where there is a
<a>tag in the contenteditable element.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2024-01-26.at.08-50-26.mp4