Block editor: reduce getBlockEditingMode calls #58310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
force-pushed
the
fix/block-selector-remove-non-selectors
branch
from
4d8de63 to
3e744aa
Compare
|
Size Change: +69 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ellatrix
changed the title
ellatrix
commented
Jan 27, 2024
| hasOverlay: __unstableHasActiveBlockOverlayActive( | ||
| clientId, | ||
| blockEditingMode | ||
| ), |
There was a problem hiding this comment.
This is an unstable selector, so it seems ok to add optional parameters for now.
ellatrix
commented
Jan 27, 2024
| getBlockAttributes( state, clientId ), | ||
| getBlockEditingMode( state, rootClientId ), | ||
| getTemplateLock( state, rootClientId ) | ||
| ); |
There was a problem hiding this comment.
It's ok to get all these at once here: most blocks have attributes and have no parent template lock, so the previous early returns have no effect.
|
Flaky tests detected in b9d30ed. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7677690922
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We are currently calling
getBlockEditingModeabout ~78 000 times in the post editor for a large post (1400+ blocks) and ~168 000 in the site editor for that some post.This PR reduces to amount of calls to ~13 000 for the post editor and ~36 000 for the site editor.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast