Post Content: Update placeholder when editing template #58360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding hook to set placeholder
Only use initialTabId if a corresponding tab exists
…ed E2E test changes and more manual testing in post and site editors.
update e2e tests remove `_experimental` Flag for initialTab prop
noisysocks
added
[Type] Enhancement
noisysocks
requested review from
kevin940726,
Mamaduka,
draganescu,
talldan,
tellthemachines,
adamziel,
ellatrix,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
I selected the wrong branch 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the Post Content block's placeholder when viewing it in the context of editing a template.
I pulled this out of #57572. Props to my boy @ramonjd.
Why?
A common pinpoint when using the site editor is that users delete the Post Content block without meaning to. We hope to reduce this by making it look more like placeholder content and less like actual content.
How?
Testing Instructions