-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Content: Update placeholder when editing template #58361
Conversation
Co-authored-by: ramon <ramonjd@gmail.com>
Size Change: +176 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Flaky tests detected in 3368838. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7703659623
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (pending design 👍🏻)
I'm not a believer in this one. I regret to be the wet blanket here, but this seems an arbitrary placeholder to update, and I still don't think this will make a meaningful difference to the otherwise very legitimate issue. I think we need to look at a proper long term solution for 6.6, one that does not rely on outlines or placeholders or other noise that I worry will become vestigial and feel like bandaids we have to remove in the future. Instead we should focus on smaller improvements, like #58169, or the idea that clicking anywhere when the template and footer are locked, sets focus in the nearest editable field. |
What?
Updates the Post Content block's placeholder when viewing it in the context of editing a template.
I pulled this out of #57572. Props to my boy @ramonjd.
Why?
A common painpoint when using the site editor is that users delete the Post Content block without meaning to. We hope to reduce this by making it look more like placeholder content and less like actual content.
Testing Instructions