-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aspect ratio: remove support on the Group block for now #58414
Conversation
Flaky tests detected in 60fbfd0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7702692781
|
Thanks for the quick review, Rob! 🙇 |
Thank you! We can potentially explore re-enabling this in the future depending on how it works in the Cover block. But for now, the Cover with the DNA it shares with Image, means the two are sides of a coin and it's a good fit there. |
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 7ec2d92 |
What?
Following on from feedback on #56897, let's remove aspect ratio support from the Group block for now.
Why?
Aspect ratio support is a natural fit for the Cover block where folks are actively using min-height controls and the block has a default min height, with everything centred by default. With the Group block, positioning controls aren't exposed by default, and the use case for aspect ratio there is quite nuanced (likely only really works well with particular Row and Stack blocks, and depending on the kind of contents in use)
So, until we have a solid use case for re-enabling it and/or a good way to hide the control until it's really needed, this PR proposes leaving Group block without aspect ratio support for WP 6.5. This will give us a bit more time to consider whether or not it should be included with the Group block further down the track, as it will be much easier to re-add the control than to remove it once it's in a major release.
How?
block.json
file to remove aspect ratio supportTesting Instructions
Testing Instructions for Keyboard
Screenshots or screencast