-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate remaining 'pattern block' e2e tests to Playwright #58486
Conversation
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
Flaky tests detected in 5dd141f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7722551187
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- All tests are migrated as expected.
- Assertions are now more robust with
toMatchObject
- I also checked the tests that have already been migrated and there are no duplicate test scenarios.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to
GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
5dd141f
to
e05d9dd
Compare
Thanks for the review, @t-hamano! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! ❤️
What?
Part of #38851.
PR migrates remaining 'pattern block' e2e tests to Playwright.
Why?
See #38851.
Testing Instructions