-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve translators comments for wp.date.setSettings in compat file #58488
Improve translators comments for wp.date.setSettings in compat file #58488
Conversation
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/script-loader.php |
Flaky tests detected in 6b99735. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7723259510
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Oh great, thanks for catching that 🙇🏻 |
I suppose this will also need a backport I've added a note to: |
I've raised a sync at:
@afercia I've copied the changes directly from the compat file but a confidence check would be appreciated. |
Follow-up to #56682 and #58479
While looking at the above pull requests I noticed some translators comments can be improved.
These comments need to be improved for Core as well. The Trac ticket https://core.trac.wordpress.org/ticket/60105 can be a good place to do that.
What?
A few translators comments have incorrect placeholders reference or unnecessary ones.
Why?
To make translators happy.
How?
Use correct format for translators comments.
Testing Instructions
This quick PR only changes translators comments.
Testing Instructions for Keyboard
Screenshots or screencast