Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve translators comments for wp.date.setSettings in compat file #58488

Merged

Conversation

afercia
Copy link
Contributor

@afercia afercia commented Jan 31, 2024

Follow-up to #56682 and #58479

While looking at the above pull requests I noticed some translators comments can be improved.
These comments need to be improved for Core as well. The Trac ticket https://core.trac.wordpress.org/ticket/60105 can be a good place to do that.

What?

A few translators comments have incorrect placeholders reference or unnecessary ones.

Why?

To make translators happy.

How?

Use correct format for translators comments.

Testing Instructions

This quick PR only changes translators comments.

Testing Instructions for Keyboard

Screenshots or screencast

@afercia afercia added [Type] Enhancement A suggestion for improvement. l10n Localization and translations best practices labels Jan 31, 2024
@afercia afercia requested a review from spacedmonkey as a code owner January 31, 2024 08:33
@afercia afercia requested a review from ramonjd January 31, 2024 08:33
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.5/script-loader.php

Copy link

Flaky tests detected in 6b99735.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7723259510
📝 Reported issues:

@t-hamano t-hamano self-requested a review January 31, 2024 11:08
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ramonjd
Copy link
Member

ramonjd commented Jan 31, 2024

Oh great, thanks for catching that 🙇🏻

@ramonjd ramonjd merged commit ceb3c1c into trunk Jan 31, 2024
60 of 61 checks passed
@ramonjd ramonjd deleted the fix/translators-comments-wp-date-setsettings-compat-file branch January 31, 2024 22:04
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Jan 31, 2024
@ramonjd
Copy link
Member

ramonjd commented Jan 31, 2024

I suppose this will also need a backport

I've added a note to:

@getdave
Copy link
Contributor

getdave commented Feb 1, 2024

I suppose this will also need a backport

I've added a note to:

I've raised a sync at:

@afercia I've copied the changes directly from the compat file but a confidence check would be appreciated.

@youknowriad youknowriad added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Needs PHP backport Needs PHP backport to Core labels Feb 8, 2024
@MaggieCabrera MaggieCabrera added the [Package] Date /packages/date label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core l10n Localization and translations best practices [Package] Date /packages/date [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants