Support button's link settings for Pattern Overrides #58587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Feature] Synced Patterns
kevin940726
requested review from
spacedmonkey,
Mamaduka and
ajitbohra
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/blocks.php |
|
Size Change: +40 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
kevin940726
force-pushed
the
add/pattern-overrides-links
branch
from
2a33a4d to
b799c2d
Compare
|
Flaky tests detected in b799c2d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7781362451
|
49 tasks
talldan
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
LGTM, and it tests well. I'm not a huge fan of the markup it leaves when an override unsets one of the values:
<button href="https://wordpress.org" rel target />However, I'm not sure much can be done about that right now, and I don't think it has any effect on the usability. Given the html is being manipulated dynamically, it's something that can be improved later on.
On that note, it might be worth following up with an issue to discuss the problem and what solutions there might be.
Also, just to check, @SantosGuillamot Are you happy for block binding support to be added for these attributes?
| content[ blockId ].values[ attributeKey ] = | ||
| block.attributes[ attributeKey ]; | ||
| block.attributes[ attributeKey ] === undefined |
There was a problem hiding this comment.
It makes me a little nervous that this might have unintended consequences on other blocks, but it's not a big issue right now while there's a limited number of blocks supported.
An alternative could be maintaining a list of blocks and attributes near this code that this fix/hack should apply to.
There was a problem hiding this comment.
I think we can (and probably should) adjust this as we support more blocks. There's already a TODO comment below this line so I think it's enough for now?
FWIW, the HTML Tag Processor API does support a |
I believe is not that useful for other cases like "Post meta", but as long as it works for your use case, I believe it shouldn't be an issue to support them.
If I am not mistaken, the HTML API removes the attribute if the value is $value = _wp_array_get( $block_instance->context, array( 'pattern/overrides', $block_id, 'values', $attribute_name ), null );
return $value === '' ? false : $value; |
This was referenced Feb 9, 2024
|
Backport WordPress/wordpress-develop#6072 |
youknowriad
added
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #53705. Support both
linkTargetandrelofcore/buttonfor Pattern Overrides.Why?
These attributes are editable in the UI but not saved in the overrides.
How?
Use an empty string to represent
undefinedfor now until the block binding API supports a richer format.Testing Instructions
Added an e2e test.
Screenshots or screencast