-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drag and drop: Allow dragging from inserter or desktop to template parts #58589
Merged
andrewserong
merged 4 commits into
trunk
from
fix/dragging-to-template-parts-for-block-inserter-and-drag-from-desktop
Feb 5, 2024
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1b45d68
Drag and drop: Allow dragging from inserter or desktop to template parts
andrewserong 8fd632b
Add comment
andrewserong d8a3894
Simplify return statement because we know it'll always be a boolean
andrewserong a77cb22
Add tests, clarify selector
andrewserong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1246,6 +1246,27 @@ export function isTyping( state = false, action ) { | |
return state; | ||
} | ||
|
||
/** | ||
* Reducer returning dragging state. It is possible for a user to be dragging | ||
* data from outside of the editor, so this state is separate from `draggedBlocks`. | ||
* | ||
* @param {boolean} state Current state. | ||
* @param {Object} action Dispatched action. | ||
* | ||
* @return {boolean} Updated state. | ||
*/ | ||
export function isDragging( state = false, action ) { | ||
switch ( action.type ) { | ||
case 'START_DRAGGING': | ||
return true; | ||
|
||
case 'STOP_DRAGGING': | ||
return false; | ||
} | ||
|
||
return state; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think our unit test coverage for selectors, actions, and reducers is very high so should probably maintain that by adding unit tests for these new ones. Even though they're painfully simple... maybe ChatGPT can write tests for you. |
||
|
||
/** | ||
* Reducer returning dragged block client id. | ||
* | ||
|
@@ -2048,6 +2069,7 @@ function blockPatterns( state = [], action ) { | |
|
||
const combinedReducers = combineReducers( { | ||
blocks, | ||
isDragging, | ||
isTyping, | ||
isBlockInterfaceHidden, | ||
draggedBlocks, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it still necessary to have
isDraggingBlocks
given the addition ofisDragging
? When would one use one and not the other? Where do we still useisDraggingBlocks
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem to be used much but it's a public API so we can't really get rid of it altogether 😅
We could maybe refactor existing uses of it but that's better done as a separate PR I reckon. Not sure if there is a case for knowing that the thing being dragged is specifically a block 🤔