Update Font Library non-REST API code to align with Core standards

[getdave]

What?

Aligns the Font Library code with Core PHP standards.

See #55277 (comment)

Co-authored-by: getdave get_dave@git.wordpress.org
Co-authored-by: anton-vlasenko antonvlasenko@git.wordpress.org
Co-authored-by: hellofromtonya hellofromtonya@git.wordpress.org
Co-authored-by: pbking pbking@git.wordpress.org

⚠️ Questions

• Do we want wp_unregister_font_collection to provide a return value because currently it doesn't.
• google-fonts-to-wordpress-collection has a TODO to update to "production font collection":
  • will we do this at point of merge? If not we should provide a more detailed comment.
  • a build process for this can be handled after the initial Core merge.
  • should we make this into a constant?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: antonvlasenko, get_dave, hellofromtonya, mmaattiiaass, pbking.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: anton@antons-mac-mini.local.

Co-authored-by: anton-vlasenko <antonvlasenko@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: hellofromtonya <hellofromtonya@git.wordpress.org>
Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: pbking <pbking@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.5/fonts/class-wp-font-collection.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-font-library.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-font-utils.php
❔ lib/compat/wordpress-6.5/fonts/fonts.php

[getdave]

I believe this was incorrect but flagging just in case.

[getdave]

I'm going to try and rebase this now.

[anton-vlasenko]

I'm going to try and rebase this now.

Thanks. I will abstain from committing code for now.

[pbking]

Do we want wp_unregister_font_collection to provide a return value because currently it doesn't.

Yes, I believe it should return the response of unregister_font_collection

[getdave]

Yes, I believe it should return the response of unregister_font_collection

✅ in 4373d07

[getdave]

@pbking Are you able to advise on the Google fonts collection URL?

[matiasbenedetto]

@pbking Are you able to advise on the Google fonts collection URL?

@getdave I think this thread can have the answer to this:
#58530 (comment)

[getdave]

@anton-vlasenko Are we in a good place to merge this now?

[anton-vlasenko]

@anton-vlasenko Are we in a good place to merge this now?

@getdave
No, something strange happened to my working copy.
I think I need 30 minutes to double check everything.
I will ping you when it's ready.

[github-actions]

Flaky tests detected in ac52e89.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7761362749
📝 Reported issues:

• [Flaky Test] Should insert content using the global inserter #57525 in /test/e2e/specs/widgets/editing-widgets.spec.js

[anton-vlasenko]

@getdave, I think it's good to go. Just not sure where this bit in the fonts.php file came from, but it looks like we should keep it:

function gutenberg_init_font_library() {
	gutenberg_create_initial_post_types();
	gutenberg_create_initial_rest_routes();
}

There were tons of changes in the trunk, so I had to start this PR from scratch.

[matiasbenedetto]

Just not sure where this bit in the fonts.php file came from, but it looks like we should keep it:

@anton-vlasenko it seems valid. It's not adding anything new, just calling some parts of the code differently. It seems like added recently vs what's in trunk. In both cases (trunk and this branch) the code invoked is working fine. It's safe to add.

[matiasbenedetto]

Thanks for the enhancements. The changes look good to me.