Fix URLPopover preview overflow #58741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Feature] UI Components
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +531 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Feb 7, 2024
Please go ahead 👍 I'm happy that this is merged if you ✅ |
t-hamano
approved these changes
Feb 7, 2024
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
|
I forced merge this because the PHP Unit test failures are unrelated and were due to another issue which is now resolved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Stops the preview for URL Popover growing wider than the max modal width constant.
Fixes #58599
Why?
We don't want hugely wide popovers when URLs are long.
How?
Use max-width.
Testing Instructions
https://make.wordpress.org/core/handbook/tutorials/linking-your-github-and-w-org-profiles/#4-add-your-wordpress-org-git-email-to-your-github-email-listTesting Instructions for Keyboard
Screenshots or screencast