-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove open in new tab from link preview #58744
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN:
GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -59 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
4aa7bef
to
cf112d7
Compare
cf112d7
to
e91e505
Compare
61d3d03
to
4106d25
Compare
4106d25
to
8d3385d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it
I restarted the React Native tests. If they fail again then let's reach out in #mobile on WP Slack to see if the failure is legit. If it's a false flag then we can force merge this one. |
Good stuff, thanks! |
👋 Hi @scruffian! Just a friendly reminder to manually review, update as needed, and include the If it was on accident, no big deal! But just trying to make sure everyone is aware as we retrain our brains. 😄 |
Oh yeah sorry :( |
What?
Removes open in new tab from link control preview as a follow-up to #58183
Why?
Adding the "Opens in new tab" checkbox to the preview was a temporary stop gap solution to allow content creators to more easily updated created links. This was because we previously remove the "Settings" controls from the initial link creation step and this caused some unexpected UX issues for certain users.
Recent advancements in the UX of the Link UI however, mean that the UI remains open after the initial link creation. This means users now need only click "Edit" to access the
Opens in new tab
.This workflow should be sufficient to avoid overburdening users who regularly create links that must open in a new tab.
In the future iterations on the Link UI, we may even default to the "Edit" view upon initial link creation which would further streamline this flow.
For now however, it makes sense to remove the "hotfix" which gave special precedence to the
Opens in new tab
. This unifies the control and standardises the interface.How?
Removes
addionalControls
from<LinkPreview />
component.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast