Data Module: Refactor the Post Type Capabilities fetching to use the data module #5875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
commented
Mar 29, 2018
| yield receiveUserPostTypeCapabilities( postTypeSlug, userWithCapabilities.post_type_capabilities ); | ||
| } | ||
|
|
||
| export const getUserPostTypeCapability = getUserPostTypeCapabilities; |
There was a problem hiding this comment.
Right now this is hacky as it creates several requests if we pass different capabilities. A solution for these is being discussed in #5826
youknowriad
force-pushed
the
update/post-type-capabilities
branch
from
2aa92b6 to
ea5d39c
Compare
This was referenced Apr 9, 2018
|
Closing this as it's a bit outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is part of a series of pull request targeted at more complex use of selector resolvers introduced in #5219.
The current PR moves the fetching of the post type user capabilities to the data module.
Testing instructions
Check that you can publish properly and that the sidebar panels show up as expected.