Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Clarify the performance reference commit and how to pick it #58927

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Documentation: Clarify the performance reference commit and how to pick it #58927

merged 3 commits into from
Feb 12, 2024

Conversation

youknowriad
Copy link
Contributor

Just adds some clarifications about the performance job, the codevitals dashboard and the reference commit used.

@youknowriad youknowriad added the [Type] Developer Documentation Documentation for developers label Feb 12, 2024
@youknowriad youknowriad requested review from Mamaduka, getdave, ndiego and a team February 12, 2024 09:54
@youknowriad youknowriad self-assigned this Feb 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

youknowriad and others added 2 commits February 12, 2024 11:04
@youknowriad @ntsekouras
Tweaks
9be4150 
Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
@youknowriad @ntsekouras
More fixes.
7ba42fc 
Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
ntsekouras
ntsekouras approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Riad!

@github-actions GitHub Actions
Copy link

Flaky tests detected in 04d1732.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7869960795
📝 Reported issues:

@youknowriad youknowriad merged commit 4337c64 into trunk Feb 12, 2024
58 checks passed
@youknowriad youknowriad deleted the doc/performance-reference-commit branch February 12, 2024 10:46
@github-actions github-actions bot added this to the Gutenberg 17.8 milestone Feb 12, 2024
aristath added a commit that referenced this pull request Feb 13, 2024
@aristath
Merge branch 'trunk' into try/fix-form-styles
f612d4e 
* trunk: (273 commits)
  Remove preffered style variations legacy support (#58930)
  Style theme variations: add property extraction and merge utils (#58803)
  Migrate `change-detection` to Playwright (#58767)
  Update Changelog for 17.6.6
  Docs: Clarify the status of the wp-block-styles theme support, and its intent (#58915)
  Use `data_wp_context` helper in core blocks and remove `data-wp-interactive` object (#58943)
  Try double enter for details block. (#58903)
  Template revisions API: move from experimental to compat/6.4 (#58920)
  Editor: Remove inline toolbar preference (#58945)
  Clean up link control CSS. (#58934)
  Font Library: Show error message when no fonts found to install (#58914)
  Block Bindings: lock editing of blocks by default (#58787)
  Editor: Remove the 'all' rendering mode (#58935)
  Pagination Numbers: Add `data-wp-key` to pagination numbers if enhanced pagination is enabled (#58189)
  Close link preview if collapsed selection when creating link (#58896)
  Fix incorrect useAnchor positioning when switching from virtual to rich text elements (#58900)
  Upgrade Floating UI packages, fix nested iframe positioning bug (#58932)
  Site editor: fix start patterns store selector (#58813)
  Revert "Rich text: pad multiple spaces through en/em replacement (#56341)" (#58792)
  Documentation: Clarify the performance reference commit and how to pick it (#58927)
  ...
@Mamaduka Mamaduka mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@Mamaduka Mamaduka Mamaduka approved these changes

@getdave getdave Awaiting requested review from getdave

@ndiego ndiego Awaiting requested review from ndiego ndiego is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@youknowriad youknowriad

Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 17.8
Development

Successfully merging this pull request may close these issues.
3 participants
@youknowriad @Mamaduka @ntsekouras