-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataViews: Add loading/no results message in grid view #59002
Conversation
Size Change: +82 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Flaky tests detected in bac80fd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7899535635
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
I just cherry-picked this PR to the more/backports-for-beta3 branch to get it included in the next release: 1e70298 |
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
What?
Fixes: #58482
This PR adds a simple loading and no results message in DataViews grid view. For now is just a simple text, identical to
table
andlist
views.I had to update a bit the hooks used for patterns fetching, because in some cases the
isResolving
value was hardcoded tofalse
.Testing Instructions
Screenshots or screencast