Tabs: rename initialTabId prop to defaultTabId
#59035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 17f4a1c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7935511638
|
chad1008
force-pushed
the
tabs/rename-initialtabid
branch
from
19c51d2 to
6f70aa7
Compare
chad1008
force-pushed
the
tabs/rename-initialtabid
branch
from
6f70aa7 to
46c4499
Compare
chad1008
requested review from
talldan,
ajitbohra and
ellatrix
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Good catch, i'm not sure why i missed those in my initial search, thank you. The changes look good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #52997 (comment)
What?
Renames the
Tabscomponent'sinitialTabIdprop todefaultTabIdWhy?
It more clearly and more consistently communicates what the prop does.
How?
Testing Instructions
All tests should continue to pass