Font Library: do not match firefox for iOS in the JS loading font face name formatting exception. #59037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
matiasbenedetto
added
[Type] Bug
matiasbenedetto
added
the
Backport to Gutenberg RC
|
Size Change: -10 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fd40018. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7907200864
|
creativecoder
approved these changes
Feb 15, 2024
youknowriad
added
Backport to WP 6.7 Beta/RC
|
I'm guessing that you mean the "backport to WP Beta/RC" label right? |
Yes, sorry about the confusion. |
getdave
pushed a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: creativecoder <grantmkin@git.wordpress.org>
|
I just cherry-picked this PR to the cherry-pick-beta-2 branch to get it included in the next release: 331f046 |
getdave
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: creativecoder <grantmkin@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Do not match Firefox for iOS in the conditional formatting for font face name needed for Firefox Gecko browsers.
This change was added here: #59019.
Props to @creativecoder for noticing that.
Why?
Firefox for iOS should not be targeted because it is not Gecko-based but WebKit based.
Reference: https://firefox-source-docs.mozilla.org/overview/ios.html
How?
Removing the user agent name used by Firefox for iOS.