Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Soft deprecate component #59182

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Navigation: Soft deprecate component #59182

merged 4 commits into from
Apr 15, 2024

Conversation

mirka
Copy link
Member

@mirka mirka commented Feb 19, 2024

What?

Soft deprecates the Navigation component, to discourage new usage and to signal that it is in maintenance mode.

Why?

Usage of the Navigation component has been dropped in Gutenberg in favor of Navigator. We don't think a lot of extenders are using this component, and it's unlikely that we'll do any dev work on it anymore. @ciampo and I agreed that we should deprecate it.

@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Feb 19, 2024
@mirka mirka self-assigned this Feb 19, 2024
Copy link

Flaky tests detected in fa8d6e5.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7962308816
📝 Reported issues:

@mirka mirka force-pushed the deprecate-navigation branch from fa8d6e5 to 26ebc51 Compare April 12, 2024 13:44
@mirka mirka force-pushed the deprecate-navigation branch from 26ebc51 to 18c86af Compare April 12, 2024 13:45
@@ -1,10 +1,19 @@
<script>
( function redirectIfStoryMoved() {
const PREVIOUSLY_EXPERIMENTAL_COMPONENTS = [ 'navigation' ];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add components to this list as we remove their experimental status (#59418), and once all of them are done we can simplify to a bulk redirect on components-experimental- prefixes.

More info on the redirect mechanism at #59181.

@mirka mirka marked this pull request as ready for review April 12, 2024 13:58
@mirka mirka requested a review from ajitbohra as a code owner April 12, 2024 13:58
@mirka mirka requested a review from a team April 12, 2024 13:58
Copy link

github-actions bot commented Apr 12, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thanks!

@mirka mirka merged commit b06dbb9 into trunk Apr 15, 2024
66 checks passed
@mirka mirka deleted the deprecate-navigation branch April 15, 2024 16:34
@github-actions github-actions bot added this to the Gutenberg 18.2 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants