-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Storybook validator to static checks workflow #59189
base: trunk
Are you sure you want to change the base?
Conversation
Size Change: -1 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Flaky tests detected in 98ef30f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7967847308
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this one!
It isn't really a static check, though, is it? It requires building the packages and storybook itself, so should it be separate from the static checks workflow?
What?
Adds a static check to validate Storybook build status
Why?
To ensure that Storybook isn't accidentally broken
How?
Adds a new script to
package.json
calledstorybook:validate
, then calls that from within thestatic-checks
workflow.Testing Instructions
The PR should test itself!