Fix: Don't render the Transform Into panel if there are no patterns #59217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
MaggieCabrera
approved these changes
Feb 20, 2024
|
Size Change: +2 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
fix/dont-render-template-panel-if-there-are-not-enought-patterns-to-show
branch
from
fc6cf9e to
11db58f
Compare
|
Themes may want to define patterns for alternative templates that are not the one present on the template they are replacing, we shouldn't assume that a theme will do exactly like TT4 does, if there's a pattern for the template, it should show |
jorgefilipecosta
deleted the
fix/dont-render-template-panel-if-there-are-not-enought-patterns-to-show
branch
|
Flaky tests detected in 11db58f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7976589592
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #55091.
Fixes a bug where the "Transform into" panel is still displayed even if there are no patterns for a template type.
Updates the code to render patterns even if there is only one pattern for the template type as suggested by @MaggieCabrera. Previously it needed at least two patterns for a template type for patterns to be shown.
Testing Instructions
When the 2024 theme is active, go to the site editor and check if the "Transforms Into" panel is not displayed on the 404 template.