-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
env: Fix mariadb version to LTS #59237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a changelog entry as well
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
Flaky tests detected in 8d48730. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7989268543
|
I can confirm that for the learn.wordpress.org local development environment built on top of wp-env, this fix does allow wp-env to start. |
Works for me! Thanks @t-hamano |
This approach seems to work. I think that the reason why the performance test fails is because wp-env does not start on trunk. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @deanpienaar, @dmaziar, @adimoldovan, @ramonschriks, @sweber83. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Okay, let's merge this. |
The "Compare performance width base branch" performance test seems to fail on trunk. Is this because the base branch still references the latest version of |
I think so, yes. It will work again once MariaDB push out a new version, which should be fairly soon I imagine |
…he default charset change in MariaDB v11.3.1. Ref: - https://jira.mariadb.org/browse/MDEV-32975 - WordPress/gutenberg#59237
Reverts #25223 and upgrades `wp-env` to 9.4.0 which uses MariaDB LTS instead of latest WordPress/gutenberg#59237 --------- Co-authored-by: ElementorBot <48412871+elementorbot@users.noreply.github.com>
Reverts elementor#25223 and upgrades `wp-env` to 9.4.0 which uses MariaDB LTS instead of latest WordPress/gutenberg#59237 --------- Co-authored-by: ElementorBot <48412871+elementorbot@users.noreply.github.com>
What?
This PR fixes the connection failure to the database by pinning the version of mariadb to LTS and testing if GitHub Actions pass.
Please check this out for details: https://wordpress.slack.com/archives/C02QB2JS7/p1708499504613749
Fixes #59232
Why?
There seems to be a problem with the latest version of the
mariadb
image, as seen in the issue below.MariaDB/mariadb-docker#560
How?
Pin the image version to
lts
.Testing Instructions
Hopefully, wp-env should now start successfully and pass GitHub Actions successfully.