Top Toolbar: Fix 'collapsed' state synchronization #59267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Regression
Mamaduka
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: +20 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5b32de9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8000492105
|
|
Thanks for noticing and getting a PR in! I have a #58979 that adds a hook to make it more reliable to know the state if the toolbar is showing or not. I believe that PR would fix this as well. Would you be willing to give it a review? 🙏🏻 |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@jeryj, I'm sure happy to help with testing and reviews. However, I think we should avoid cherry-picking extensive refactoring like that in the WP beta releases. We can merge this as a stopgap fix for WP 6.5 and continue work on #58979. Update: The refactor PR currently doesn't include a side-effect fix. |
t-hamano
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
LGTM !
- Block toolbar expands whenever a new block is selected
- No unnecessary vertical separators are displayed when a post title is selected.
I also think it's better to backport only smaller regression fixes to WP6.5 for now.
9910ace44615e910b8edc0606b441567.mp4
|
Agreed! I’d rather not include include the larger refactor as well.
|
jeryj
approved these changes
Feb 22, 2024
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org>
|
I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: ed1e641 |
getdave
added
Backported to WP Core
9 tasks
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #59263.
PR fixes 'collapsed' state synchronization for the Top Toolbar in the post editor.
Why?
The side-effect should react to every block selection state, not only when there is block selection or not.
How?
blockSelectionStartto reset the block toolbar's collapsed state.is-collapsedclass. The toolbar always collapses when there's no block selection.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2024-02-22.at.10.27.49.mp4