Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Tests: Adding a test to check CPT templates initialization. #5929

Merged
merged 3 commits into from
Apr 4, 2018

Conversation

youknowriad
Copy link
Contributor

blocked by #5906

This PR adds test plugins to Gutenberg, these plugins can be used in E2E tests. The test plugins folders includes a single plugin for now to test CPT templates.

This pattern could be used to fix this #5909

@youknowriad youknowriad added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Apr 2, 2018
@youknowriad youknowriad self-assigned this Apr 2, 2018
@@ -0,0 +1,46 @@
<?php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to have a dozen or more test plugins eventually, does it make sense to have a more verbose file naming scheme than templates.php?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see us having probably a dozen of plugins here. I'm open to suggestions on the naming. It's not that critical at the moment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's refactor when this becomes an issue. It's going to be easier to come up with a pattern when we have more files there.

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowriad youknowriad merged commit 0eff0bb into master Apr 4, 2018
@youknowriad youknowriad deleted the add/templates-e2e-test branch April 4, 2018 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants