-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove scrolling of empty image blocks. #59305
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +67 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
Whilst the solution you added here works, it is too broadly applied. Currently this style update here applies to all instances of the Placeholder component. Which is used by many blocks in many instances.
Instead of making this change here in the placeholder component CSS this should be done in the editor.css
file of the imabe block scoped to only apply to the placeholder nested inside an image block
Flaky tests detected in 7cfd5a8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8016251353
|
@fabiankaegy Thank you for reviewing! Fixed to be controlled by editor.css in the image block. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now works as expected :) thanks!
Alternative fix here: #59857 |
What?
Remove scrolling of empty image blocks.
Why?
Fix #59226.
How?
Show
.components-placeholder__fieldset
onlyis-selected
.Testing Instructions
It seems easiest to produce with the 'Team members' pattern that's included with WordPress 6.4/6.5 by default.
Testing Instructions for Keyboard
Screenshots or screencast