Change default "Connected to a custom field" message in bindings #59434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Bug
SantosGuillamot
requested review from
artemiomorales and
michalczaplinski
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SantosGuillamot
commented
Feb 28, 2024
This was referenced Feb 28, 2024
|
Size Change: +377 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
I just cherry-picked this PR to the update/packages-6.5-rc1 branch to get it included in the next release: b423ff5 |
youknowriad
added
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Right now, for all the sources, we are showing “Connected to a custom field”: link. This means that, if I use a different source, it still shows the same message, which is not correct because it might not be a custom field.
Why?
It might be confusing for users when they use a source that is not "Post meta".
How?
I suggested using a more generic message that looks like "Connected to { source_label }". And, if the label doesn't exist because the source hasn't been registered in the editor, shows "Connected to dynamic data".
Testing Instructions
Repeat the process but connecting the alt and title attributes instead.