Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: useBlockTools cleanup #59450

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Refactor: useBlockTools cleanup #59450

merged 3 commits into from
Apr 5, 2024

Commits on Mar 15, 2024

  1. Pass full block object

    @jeryj @draganescu
    jeryj authored and draganescu committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    cbc29cd View commit details
    Browse the repository at this point in the history

  2. Use getBlockSelectionStart to check for selectedBlockClientId 

    selectedBlockClientIds() does quite a bit more work, when we only need one of the selected block ids. Generally, this will only be one block id. In the case of multiples, the previous method would get the topmost block in the selection in the array. getBlockSelectionStart gets the block where selection starts, which is a slightly different concept. Functionally, I think the outcome is identical, and getBlockSelectionStart should be faster.
    @jeryj @draganescu
    jeryj authored and draganescu committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    00133b4 View commit details
    Browse the repository at this point in the history

  3. some nits

    @draganescu
    draganescu committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    616d285 View commit details
    Browse the repository at this point in the history