Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only check for 'other' block control slot in useHasAnyBlockControls #59884

Closed
wants to merge 4 commits into from
Closed

Only check for 'other' block control slot in useHasAnyBlockControls #59884

wants to merge 4 commits into from

Commits on Apr 3, 2024

  1. Only check for 'other' block control slot 

    The useHasAnyBlockControls hook is a hefty way of checking if we are in contentOnly mode for image and featured image blocks. This reduces the performance impact while we figure out what to do in a more permanent way.
    @jeryj
    jeryj committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    e9f1447 View commit details
    Browse the repository at this point in the history

  2. Move block toolbar check to before rendering the block toolbar

    @jeryj
    jeryj committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    134691e View commit details
    Browse the repository at this point in the history

  3. Rename to useHasOtherBlockControls

    @jeryj
    jeryj committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    6f3db75 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Try removing checking for slot fills on contentOnly 

    What breaks? Can we solve that in a different way without checking for the presence of fills in any slots?
    @jeryj
    jeryj committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    b5ff7c9 View commit details
    Browse the repository at this point in the history