State: Prevent unnecessary state updates to edit-post preferences #5990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5974 (comment)
This pull request seeks to resolve two issues with unnecessary state updates and dispatching to the edit post store:
combineReducers
has the benefit of avoiding state updates when each key of preferences is strictly equal.true
andfalse
, rather than unlimited states of possible set of block UIDs). With these changes, the subscribe listener will only dispatch when going from a state of cleared selection to having a selection, but not when changing selection from one block to another.Testing instructions:
Verify that there are no regressions in the behaviors of preferences (toggled panels, active sidebar, editor mode).
Repeat testing instructions from #5882, verifying no regressions.