Editor: Fix loading templates using a top level pattern block that includes a template part. #59900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cludes a template part
youknowriad
added
[Type] Bug
youknowriad
added
[Feature] Site Editor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @fushar. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +9 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
youknowriad
added
the
Backport to Gutenberg Minor Release
dsas
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
This works for me.
- Following the steps in the original issue shows me the page.
- Clicking in the editable area prompts me to click the link to edit the template
- The link differs, but I think that's a good thing
- With this PR I go to
site-editor.php?postId=bedrock-wpcom%2F%2Fpage&postType=wp_template&focusMode=true&canvas=editand can edit the header etc - With GB deactivated I go to
site-editor.php?canvas=editand can't edit the header
- With this PR I go to
- Trying to insert the pattern inside the post editor by pasing
<!-- wp:pattern {"slug":"bedrock/page"} /-->shows a blank page with a pattern placeholder in the post list.
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…cludes a template part (WordPress#59900)
Mamaduka
removed
the
Backport to Gutenberg Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #59634
Regression introduced in #58928
What?
This bug actually existed in the post editor before but was hidden (only visible in template preview mode) so when unifying this logic (hiding template parts) with the site editor, it became more visible.
Basically this PR limits the removal of the "template part" from the allowed blocks in "post-only" mode, in other words templates surrounding the pages/posts being rendered may use template parts.
1- Install bedrock theme
2- Set a static page as home page
3- Open the site editor, the page and template should load (and not be empty)