Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: update index view for pages #59950

Merged
merged 10 commits into from
Mar 21, 2024
16 changes: 14 additions & 2 deletions packages/edit-site/src/components/block-editor/editor-canvas.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@ import { computeIFrameScale } from '../../utils/math';

const { EditorCanvas: EditorCanvasRoot } = unlock( editorPrivateApis );

function EditorCanvas( { enableResizing, settings, children, ...props } ) {
function EditorCanvas( {
enableResizing,
settings,
children,
onClick,
...props
} ) {
const { hasBlocks, isFocusMode, templateType, canvasMode, isZoomOutMode } =
useSelect( ( select ) => {
const { getBlockCount, __unstableGetEditorMode } =
Expand Down Expand Up @@ -69,7 +75,13 @@ function EditorCanvas( { enableResizing, settings, children, ...props } ) {
setCanvasMode( 'edit' );
}
},
onClick: () => setCanvasMode( 'edit' ),
onClick: () => {
if ( !! onClick ) {
onClick();
} else {
setCanvasMode( 'edit' );
}
},
readonly: true,
};
const isTemplateTypeNavigation = templateType === NAVIGATION_POST_TYPE;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import { privateApis as routerPrivateApis } from '@wordpress/router';

const { useLocation } = unlock( routerPrivateApis );

export default function SiteEditorCanvas() {
export default function SiteEditorCanvas( { onClick } ) {
const location = useLocation();
const { templateType, isFocusableEntity, isViewMode } = useSelect(
( select ) => {
Expand Down Expand Up @@ -87,6 +87,7 @@ export default function SiteEditorCanvas() {
<EditorCanvas
enableResizing={ enableResizing }
settings={ settings }
onClick={ onClick }
>
{ resizeObserver }
</EditorCanvas>
Expand Down
4 changes: 2 additions & 2 deletions packages/edit-site/src/components/editor/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ const interfaceLabels = {
footer: __( 'Editor footer' ),
};

export default function Editor( { isLoading } ) {
export default function Editor( { isLoading, onClick } ) {
const {
record: editedPost,
getTitle,
Expand Down Expand Up @@ -225,7 +225,7 @@ export default function Editor( { isLoading } ) {
{ ! isLargeViewport && (
<BlockToolbar hideDragHandle />
) }
<SiteEditorCanvas />
<SiteEditorCanvas onClick={ onClick } />
<PatternModal />
</>
) }
Expand Down
38 changes: 19 additions & 19 deletions packages/edit-site/src/components/layout/router.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@ import {
TEMPLATE_PART_POST_TYPE,
} from '../../utils/constants';

const { useLocation } = unlock( routerPrivateApis );
const { useLocation, useHistory } = unlock( routerPrivateApis );

export default function useLayoutAreas() {
const isSiteEditorLoading = useIsSiteEditorLoading();
const history = useHistory();
const { params } = useLocation();
const { postType, postId, path, layout, isCustom, canvas } = params ?? {};

Expand All @@ -30,31 +31,28 @@ export default function useLayoutAreas() {

// Regular page
if ( path === '/page' ) {
const isListLayout = layout === 'list' || ! layout;
return {
areas: {
content: undefined,
preview: <Editor isLoading={ isSiteEditorLoading } />,
content: <PagePages />,
preview: isListLayout && (
<Editor
isLoading={ isSiteEditorLoading }
onClick={ () =>
history.push( {
path,
postType: 'page',
postId,
canvas: 'edit',
} )
}
/>
),
mobile:
canvas === 'edit' ? (
<Editor isLoading={ isSiteEditorLoading } />
) : undefined,
},
widths: {
content: undefined,
},
};
}

const isListLayout = isCustom !== 'true' && layout === 'list';

if ( path === '/pages' ) {
return {
areas: {
content: <PagePages />,
preview: isListLayout && (
<Editor isLoading={ isSiteEditorLoading } />
),
},
widths: {
content: isListLayout ? 380 : undefined,
},
Expand All @@ -76,6 +74,7 @@ export default function useLayoutAreas() {

// Templates
if ( path === '/wp_template' ) {
const isListLayout = isCustom !== 'true' && layout === 'list';
return {
areas: {
content: (
Expand All @@ -100,6 +99,7 @@ export default function useLayoutAreas() {

// Template parts
if ( path === '/wp_template_part/all' ) {
const isListLayout = isCustom !== 'true' && layout === 'list';
return {
areas: {
content: (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const DEFAULT_CONFIG_PER_VIEW_TYPE = {
};

const DEFAULT_PAGE_BASE = {
type: LAYOUT_TABLE,
type: LAYOUT_LIST,
search: '',
filters: [],
page: 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import DataViewItem from './dataview-item';
import CustomDataViewsList from './custom-dataviews-list';

const PATH_TO_TYPE = {
'/pages': 'page',
'/page': 'page',
};

export default function DataViewsSidebarContent() {
Expand Down

This file was deleted.

Loading
Loading