Media & Text: Make the alt text editable when featured images are used #60029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the featuredImageAlt constant and only use the mediaAlt constant for the alt text. This caveat about this is that the alt text that is set for the featured image in the media library is never used in the Media & text block. When the setting "Use featured image" is toggled, reset mediaAlt attribute to an empty string. If the alt text is changed through the option in the block settings panel, update the mediaAlt attribute. The changes to index.php ensures that: The img tag always has an alt attribute, even if the alt attribute is empty. When there is a custom alt text saved to the attribute, it is used.
|
Size Change: -23 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
carolinan
added
[Block] Media & Text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What & How?
For #60023
When the Media & text block uses a featured image, the alt text is not editable. If the image has an alt text in the media library, it shows in the alt text option in the block settings panel, but it can't be replaced or removed.
No alt text is output on the front.
The PR removes the
featuredImageAltconstant from the Media & text block and only uses themediaAltconstant for the alternative text.When the setting "Use featured image" is toggled, it resets the
mediaAltattribute to an empty string.If the alt text is changed through the option in the block settings panel, the
mediaAltattribute is updated.The changes to index.php ensures that:
The changes to block.json ensures that the block does not try to populate the
mediaAltattribute with an empty string from the markup when the featured image is used. Or at least that is what I think it does- this is one point I would need help with.Testing Instructions
Add a Media & text block with a featured image, and change the alt text.
Also test for any other regressions with the alt text for standard images.