Search Block: Apply font-related style inheritance to input field #60321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +1.39 kB (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Thanks for this PR @t-hamano
| Before | After |
|---|---|
 |
 |
Things are working as described. I think we're missing one declaration text-transform: inherit;
text-decoration is unset here:
So I guess we don't need that.
There was a problem hiding this comment.
Thanks for this enhancement @t-hamano 👍
It's testing mostly as advertised. There's still a couple of typography related styles missing though.
- Text transform (as Ramon noted)
- Font style
You can see the italic font style getting picked up by the search block's label but not the input in the screenshot below:
Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
|
Thank you for noticing what I had missed! I added the missing styles and updated the screenshot as well. |
aaronrobertshaw
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Appreciate the quick iteration @t-hamano 👍
The input is inheriting all the applicable typography styles now on both the frontend and in the editor.
I did notice one inconsistency between the editor and frontend for the button though. The search block's button doesn't inherit the text transform style on the frontend. Taking a closer look at the button's styles might be a good follow-up.
| Editor | Frontend |
|---|---|
 |
 |
|
Nice catch on |
|
@aaronrobertshaw @ramonjd Thanks for the review!
Thank you for finding it. I would like to file an issue regarding this point. |
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…rdPress#60321) * Search Block: Apply font-related style inheritance to input field * Add missin styles Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> --------- Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: gigitux <gigitux@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60174
What?
This PR adds CSS properties to the input element inside the Search block that inherits font-related styles. This ensures that when typography styles are defined at the root level, they are correctly applied to the input element as well.
The screenshot below is from Emptytheme:
Before
After
Why?
According to MDN, form-related elements are browser-specific and do not inherit font-related styles. This is not an issue when typography-related styles are applied at the block level in the global styles or on individual blocks, but it becomes an issue when typography-related settings are applied at the root level in the global styles.
How?
Applies CSS to the input element that inherits all font-related styles. We also use :where to reduce the CSS specificity so that we can override this style. Only
text-decorationis not inherited. This is because it causes problems with text input, as discussed in #43499.Ideally, it would be more convenient to define these styles for the input field in the default theme.json, but the current theme.json does not support input elements.
Testing Instructions
Screenshots or screencast
f84aae4f7cc8273f8e705b0bc2b371b7.mp4