-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Move PluginPostPublishPanel and PluginPrePublishPanel to editor package #60344
Editor: Move PluginPostPublishPanel and PluginPrePublishPanel to editor package #60344
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +62 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ntsekouras!
The changes work as expected. I used the publish-panel.js
example plugin for testing.
The failing unit test will need fixing before we can land this.
98988f6
to
bfe1784
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test but the changes make sense.
…or package (WordPress#60344) Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
I see the editor package docs and slotfills reference still using the import from I guess there's no hurry before 6.6, since even afterward the old import will work for two core versions. But does it make sense to change such required doc-changes somewhere? |
In general, we used to make the changes to the documentation as we make the changes to the code. So we could make them right now. It's true that it might confuse some developers but I feel like this is a problem that should be solved in the site (have a version selector or something) |
Thanks for the information, then I will make a PR for docs. |
follow up to WordPress#60344
What?
Related: #52632, #59878
Extracted from: #60289
This PR moves PluginPostPublishPanel and PluginPrePublishPanel to editor package. This is a prerequisite for unifying the publishing flow between post and site editors.
Testing Instructions
edit-post
packages works as beforeeditor
package.Example code:
Notes
The editor package doesn't auto generate docs and will explore this separately. I'll have a PR soon for that.