Hide 'Advanced' options by default.

[DannyCooper]

Description

Hide the 'Advanced' options in the Inspector by default.

By definition 'Advanced' options won't be used by most of the time so it makes sense to hide them behind a toggle.

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code has proper inline documentation.

[paulwilde]

Agreed. Also I'm not sure whether it's been implemented (and would be separate from this PR anyway), but it'd also be nice if the open/closed state is saved per user.

[jasmussen]

With this PR merged, the "Advanced" box at the bottom of this panel, and all block panels, will start off closed, correct?

If yes, then sure, I've no objection to this. I also have no strong opinions personally.

I do tend to agree with Paul Wilde that it would be nice, longer term, to store this configuration on a per-user basis, so if for example you often use the advanced section open for the Gallery block (for this, for example), then the open state for that panel is remembered. But that's outside the scope of this PR.

I'll let @karmatosed make the final call, and merge, if she agrees the advanced panel should start closed.

Also, thank you for the PR! 🏅

[DannyCooper]

Hi @jasmussen,

Yes that was the intended behaviour for this PR.

[gziolo]

Code wise is good to go, waiting for @karmatosed 👍

[gziolo]

Related discussion in #6023, where @jasmussen proposes how to approach all inspector controls as a whole. In particular, this comment is relevant:

Decide a pattern for which panels are open by default. For example we could decide that only the topmost panel is open, all subsequent ones are closed. A future PR that stores this state on a user basis would then ameliorate any commonly used settings, while still keeping a strong default pattern.

[karmatosed]

I don't see anything wrong with it being closed but also really like the idea it could be per user. My only concern is how discoverable the CSS class is. We can judge that over time. It is incredibly useful for a lot of people.

[gziolo]

Agreed. Also I'm not sure whether it's been implemented (and would be separate from this PR anyway), but it'd also be nice if the open/closed state is saved per user.

Don't we have a similar behavior implemented for Document tab? If yes, it might be not that difficult to make it more general and include it for blocks, too. My only concern is how many different combinations are there to cover. There is another question whether it should work per block type, or per individual block?