DataViews: remove onDetailsChange event
#60387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Code Quality
oandregal
requested review from
mcsf,
youknowriad,
jorgefilipecosta and
ntsekouras
|
Size Change: -283 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Apr 2, 2024
|
Consider rebasing to fix the php tests. |
oandregal
force-pushed
the
remove/on-details-change
branch
from
52ffe97 to
9427bac
Compare
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #59659
Related #55083
What?
Removes the
onDetailsChangeevent for DataViews public API, that was only used for the list layout.Why?
The current direction deemphasizes the "details" in favor of supporting actions. See #59659 and #59950 (comment)
How?
Removes the
onDetailsChangeevent.Testing Instructions
It was no longer in use.